Skip to content

ADFA-3253 | Skip llama asset bundling in debug CI builds#1071

Open
jatezzz wants to merge 1 commit intostagefrom
feat/ADFA-3253-skip-llama-assets-ci
Open

ADFA-3253 | Skip llama asset bundling in debug CI builds#1071
jatezzz wants to merge 1 commit intostagefrom
feat/ADFA-3253-skip-llama-assets-ci

Conversation

@jatezzz
Copy link
Collaborator

@jatezzz jatezzz commented Mar 12, 2026

Description

This PR introduces a configurable skipLlamaAssets flag to prevent debug CI builds from triggering llama asset bundling tasks.

The objective is to reduce CI build time by avoiding expensive llama asset generation during debug APK builds while preserving the existing behavior for release builds.

Details

  • Added skipLlamaAssets flag in app/build.gradle.kts
  • Guarded llama bundling dependencies for debug assemble tasks
  • Applied the same condition to lint task wiring
  • Enabled SKIP_LLAMA_ASSETS=true in the debug CI workflow
SKIP_LLAMA_ASSETS=true ./gradlew :app:assembleV8Debug 
Screenshot 2026-03-12 at 1 13 30 PM

Ticket

ADFA-3253

Observation

Release build wiring remains unchanged to ensure bundled llama assets are still generated for release APK packaging. The change only affects debug CI builds.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

Caution

Review failed

The head commit changed during the review from 904d09a to 0f5441b.

📝 Walkthrough

Walkthrough

This PR adds conditional control over llama asset bundling via an environment variable and feature flag in the build configuration, allowing the build process to skip llama asset dependencies when the SKIP_LLAMA_ASSETS flag is enabled.

Changes

Cohort / File(s) Summary
Conditional Llama Asset Bundling
.github/workflows/debug.yml, app/build.gradle.kts
Introduces SKIP_LLAMA_ASSETS environment variable in CI workflow and implements conditional logic in build configuration to skip llama asset dependencies and tasks when flag is enabled, improving build flexibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • hal-eisen-adfa
  • itsaky-adfa
  • Daniel-ADFA

Poem

🐰 Skip the llama, swift and neat,
Build so fast with nimble feet,
Conditional flags dance with grace,
Speeding up the CI race!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: skipping llama asset bundling in debug CI builds, which matches the core objective of the PR.
Description check ✅ Passed The description is directly related to the changeset, providing clear context about the skipLlamaAssets flag, its purpose, implementation details, and impact on build times.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/ADFA-3253-skip-llama-assets-ci
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

chore: add configurable flag for llama asset dependencies
@jatezzz jatezzz force-pushed the feat/ADFA-3253-skip-llama-assets-ci branch from 904d09a to 0f5441b Compare March 13, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants