ADFA-3255 | Fix high severity Snyk vulnerabilities#1070
Merged
Conversation
Implement path traversal protection, XSS headers in local server, and clean up examples.
79785b5 to
0676caf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the 10 HIGH severity security problems recently reported by Snyk to prevent security regressions and maintain user trust.
To achieve this, the local test server (
serve-static.js) was updated to include path resolution checks that strictly prevent directory traversal, HTML output escaping to mitigate XSS risks, and strict Content-Security-Policy (CSP) andnosniffheaders. Additionally, a large number of outdated or unmaintained examples were removed from thellama.cppsubproject to drastically reduce the attack surface and eliminate flagged vulnerabilities within legacy code.Details
403 Forbiddenerror.document_5014844204682053344.mp4
Ticket
ADFA-3255
Observation
A significant portion of this patch involves the deletion of legacy example files in
subprojects/llama.cpp/examples/. This cleanup is intentional as it removes unmaintained files that trigger static analysis alerts without providing core value to the current active project.