-
Notifications
You must be signed in to change notification settings - Fork 11
next gen template initial version #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Changes from all commits
b8d63dc
2fe7247
4da6ceb
ac5a392
78b09a8
8ed158e
eb1715b
5080520
f66c881
57b4ccf
0479549
d7da774
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -136,8 +136,10 @@ class TemplateDetailsFragment : | |||||||||||||||||
| name = result.data.name, | ||||||||||||||||||
| createdAt = now, | ||||||||||||||||||
| lastModified = now, | ||||||||||||||||||
| templateName = getString(template.templateName), | ||||||||||||||||||
| language = result.data.language.name | ||||||||||||||||||
| // templateName = getString(template.templateName), | ||||||||||||||||||
| templateName = template.templateNameStr, | ||||||||||||||||||
| // language = result.data.language.name | ||||||||||||||||||
| language = result.data.language?.name ?: "unknown" | ||||||||||||||||||
|
Comment on lines
+139
to
+142
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using a string resource for the "unknown" fallback. The changes correctly adapt to the new nullable 💡 Suggested improvement- language = result.data.language?.name ?: "unknown"
+ language = result.data.language?.name ?: getString(R.string.language_unknown)Add the string resource in <string name="language_unknown">Unknown</string>📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| ) | ||||||||||||||||||
| ) | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
@@ -163,6 +165,7 @@ class TemplateDetailsFragment : | |||||||||||||||||
| template ?: return | ||||||||||||||||||
|
|
||||||||||||||||||
| binding.widgets.adapter = TemplateWidgetsListAdapter(template.widgets) | ||||||||||||||||||
| binding.title.setText(template.templateName) | ||||||||||||||||||
| //binding.title.setText(template.templateName) | ||||||||||||||||||
| binding.title.text = template.templateNameStr | ||||||||||||||||||
| } | ||||||||||||||||||
| } | ||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.