Extract formatToolLine to shared output module#120
Merged
Conversation
Extract formatToolLine from output.ts and reuse it in grep.ts so both "mcpc @fs" and "mcpc grep" display tools with the same format (space between tool name and params). https://claude.ai/code/session_013pnhFftwbtbgrAHkNxm9aL
Ensures TypeScript compilation errors (like unused imports caught by noUnusedLocals) are caught before committing, not just in CI. https://claude.ai/code/session_013pnhFftwbtbgrAHkNxm9aL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
formatToolLinefunction to be a shared utility in the output module instead of being duplicated in the grep command module.Key Changes
formatToolLinefunction fromsrc/cli/commands/grep.tstosrc/cli/output.tsand exported it as a public functionformatToolsSummaryinsrc/cli/output.tsto use the newformatToolLinefunction, eliminating inline formatting logicsrc/cli/commands/grep.tsto importformatToolLinefrom the output module instead of defining it locallyImplementation Details
https://claude.ai/code/session_013pnhFftwbtbgrAHkNxm9aL