Skip to content

Conversation

@barjin
Copy link
Member

@barjin barjin commented Jul 9, 2025

Closes #92

@barjin barjin requested a review from Copilot July 9, 2025 10:28
@barjin barjin self-assigned this Jul 9, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Jul 9, 2025
@github-actions github-actions bot added this to the 118th sprint - Tooling team milestone Jul 9, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a GitHub Actions workflow that automatically moves issues linked from draft pull requests into the “In Progress” pipeline in ZenHub.

  • Introduces a new workflow file triggering on various pull_request events
  • Fetches closing issue references via GitHub CLI GraphQL
  • Invokes zenhub-issue-manager to update each linked issue’s pipeline
Comments suppressed due to low confidence (3)

.github/workflows/update-draft-pr.yaml:32

  • This condition only runs when draft == true, so the pipeline move won’t execute when a draft is marked ready for review (draft == false). Adjust the condition or event filter to trigger on the ready_for_review action or check for draft == false.
        if: github.event.pull_request.draft == true

.github/workflows/update-draft-pr.yaml:34

  • Limiting the GraphQL query to the first 10 issues may omit additional linked issues. Consider increasing the limit or implementing pagination to ensure all references are processed.
          GITHUB_API_RESPONSE=$(gh api graphql -F query='query($owner: String!, $repoName: String!, $pr: Int!) { repository(owner: $owner, name: $repoName) { pullRequest(number: $pr) { closingIssuesReferences(first: 10) { nodes { number } } } } }' -F owner=${{ github.repository_owner }} -F repoName=${{ github.event.repository.name }} -F pr=${{ github.event.pull_request.number }} --jq '.data.repository')

.github/workflows/update-draft-pr.yaml:42

  • [nitpick] Rather than using echo into GITHUB_ENV and then ${{ env.gh_api_response }}, consider capturing the response as a step output (via GITHUB_OUTPUT) or exporting a shell variable directly. This improves readability and scopes the data to the step.
          for issue in $(echo ${{ env.gh_api_response }} | jq -r '.pullRequest.closingIssuesReferences.nodes[].number'); do

@barjin barjin closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Failed to load native binding

1 participant