Skip to content

ci: remove release concurrency group from on_master.yaml#1882

Merged
vdusek merged 1 commit intomasterfrom
fix/release-concurrency-deadlock
May 7, 2026
Merged

ci: remove release concurrency group from on_master.yaml#1882
vdusek merged 1 commit intomasterfrom
fix/release-concurrency-deadlock

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 7, 2026

Summary

The on_master.yaml workflow dispatches manual_release_beta.yaml and waits for it to finish, but both used the same release concurrency group with cancel-in-progress: false. Result: the dispatched run sat in pending forever while the parent held the slot — classic deadlock (see this stuck run).

Removing concurrency from on_master.yaml fixes it. manual_release_beta.yaml and manual_release_stable.yaml still share the release group, so serialization between actual releases is preserved.

The on_master workflow dispatches manual_release_beta.yaml and waits for it
to complete, but both shared the same `release` concurrency group, causing a
deadlock: the dispatched run sat in `pending` while the parent held the slot.
Beta/stable workflows still own the `release` group, so serialization between
releases is preserved.
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 7, 2026
@vdusek vdusek self-assigned this May 7, 2026
@vdusek vdusek requested a review from janbuchar May 7, 2026 12:52
@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.68%. Comparing base (b912177) to head (833321f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
- Coverage   92.69%   92.68%   -0.02%     
==========================================
  Files         161      161              
  Lines       11340    11340              
==========================================
- Hits        10512    10510       -2     
- Misses        828      830       +2     
Flag Coverage Δ
unit 92.68% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit 095d6cb into master May 7, 2026
32 checks passed
@vdusek vdusek deleted the fix/release-concurrency-deadlock branch May 7, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants