Skip to content

fix: Keep None values for user_data in Request #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pijukatel merged 1 commit into from
Feb 3, 2026
Merged

fix: Keep None values for user_data in Request #1707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ class Request(BaseModel):
lambda instance: user_data_adapter.dump_python(
instance,
by_alias=True,
exclude_none=True,
Copy link
Collaborator

@Pijukatel Pijukatel Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janbuchar do you remember if this had any specific reason?

Copy link
Collaborator

@janbuchar janbuchar Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't. The new behavior seems more explicit and I can't think of a problem that I could cause, so let's do this

Copy link
Collaborator

@janbuchar janbuchar Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't. The new behavior seems more explicit and I can't think of a problem that I could cause, so let's do this

exclude_none=False,
exclude_unset=True,
exclude_defaults=True,
)
Expand Down
Loading