Skip to content

fix: Set default http3=False for ImpitHttpClient #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mantisus wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: Set default http3=False for ImpitHttpClient #1685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/http_clients/_impit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def __init__(
self,
*,
persist_cookies_per_session: bool = True,
http3: bool = True,
http3: bool = False,
Copy link
Member

@barjin barjin Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, http3 support is only experimental in impit, we likely do not want to use it as the default anywhere

Copy link
Collaborator Author

@Mantisus Mantisus Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for the info. 🙂

verify: bool = True,
browser: Browser | None = 'firefox',
**async_client_kwargs: Any,
Expand Down
Loading