ci: inline beta release jobs to fix PyPI trusted publishing#63
Open
ci: inline beta release jobs to fix PyPI trusted publishing#63
Conversation
PyPI's Trusted Publishing rejects OIDC tokens issued from reusable workflows, so the beta release jobs are inlined into on_master.yaml instead of being invoked via `uses:` from manual_release_beta.yaml.
vdusek
added
t-tooling
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The automatic beta release on push to
master(example failing run) fails because PyPI's Trusted Publishing rejects OIDC tokens issued from reusable workflows:on_master.yamlwas invokingmanual_release_beta.yamlviauses:, which made the OIDC token reflect a reusable workflow call.Changes
on_master.yaml: inline the three beta release jobs (release_prepare,changelog_update,pypi_publish) directly, instead of callingmanual_release_beta.yamlas a reusable workflow.manual_release_beta.yaml: remove theworkflow_calltrigger (it is no longer invoked from another workflow) and add a comment explaining why the duplication exists.Follow-up
The PyPI Trusted Publisher for
apify-sharedis currently configured formanual_release_beta.yaml. After this is merged, an entry foron_master.yamlneeds to be added on PyPI so the automatic beta release passes verification.See: https://docs.pypi.org/trusted-publishers/troubleshooting/#reusable-workflows-on-github