Remove deprecation and older version support for nette/php-generator#441
Open
Pierstoval wants to merge 1 commit intoapi-platform:mainfrom
Open
Remove deprecation and older version support for nette/php-generator#441Pierstoval wants to merge 1 commit intoapi-platform:mainfrom
Pierstoval wants to merge 1 commit intoapi-platform:mainfrom
Conversation
Pierstoval
force-pushed
the
remove-deprecations
branch
from
479ed99 to
04896f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nette's
Visibilityclass is already used in the abstractPropertyclass here, so this means that support fornette/php-generator3 can be dropped, since theVisibilityclass was added inv4.1.7(commit here: nette/php-generator@a5711b3 ).Also,
nette/php-generator3 is not supported anymore since 2022 as of its latest release