fix(symfony): handle multiple GetCollection in cache invalidation #7951
Open
mrossard wants to merge 2 commits intoapi-platform:4.3from
Open
fix(symfony): handle multiple GetCollection in cache invalidation #7951mrossard wants to merge 2 commits intoapi-platform:4.3from
mrossard wants to merge 2 commits intoapi-platform:4.3from
Conversation
mrossard
force-pushed
the
fix-invalidation-multiple-getcollection
branch
from
55f978e to
94252cc
Compare
mrossard
force-pushed
the
fix-invalidation-multiple-getcollection
branch
from
94252cc to
1ec3ff9
Compare
Contributor
Author
|
Lots of failing tests mentioning MCP, i suppose it's not related...? |
Member
|
yeah #7950 |
Contributor
Author
ok thanks, this PR should be ready then :D |
soyuka
reviewed
May 7, 2026
| public function __construct(private readonly PurgerInterface $purger, | ||
| private readonly IriConverterInterface $iriConverter, | ||
| private readonly ResourceClassResolverInterface $resourceClassResolver, | ||
| private readonly ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, |
Member
There was a problem hiding this comment.
for bc we can't put an argument in the middle like this
Contributor
Author
There was a problem hiding this comment.
sorry, didn't think about that, i'll move it to the end.
Contributor
Author
There was a problem hiding this comment.
I'll have to make it nullable , should i then handle the case where it's null with a fallback to what's currently done ?
Member
There was a problem hiding this comment.
let me have a look as maybe that we need to do that differently?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem where when you have 2 (or more) GetCollection operations, cache invalidation is only called for one of them when you POST a new entity.