refactor: split normalizer/denormalizer#7713
Merged
soyuka merged 6 commits intoapi-platform:mainfrom May 7, 2026
Merged
Conversation
Member
soyuka
commented
Jan 28, 2026
soyuka
commented
| Q | A |
|---|---|
| Branch? | main |
| Tickets | prerequisite for #7710 |
| License | MIT |
| Doc PR | na |
soyuka
force-pushed
the
denormalizer
branch
3 times, most recently
from
a551716 to
ea40daf
Compare
| * @author Amrouche Hamza <hamza.simperfit@gmail.com> | ||
| * @author Baptiste Meyer <baptiste.meyer@gmail.com> | ||
| * | ||
| * @todo Denormalization methods should be deprecated in 5.x, use ItemDenormalizer instead |
Contributor
There was a problem hiding this comment.
Should ItemNormalizer::denormalize call ItemDenormalizer::denormalize to ensure that futur bugfix/feature will be done on both ?
Cause we're having duplicate code with denormalize no ?
| public const FORMAT = 'jsonapi'; | ||
|
|
||
| private array $componentsCache = []; | ||
| use ItemNormalizerTrait; |
Contributor
There was a problem hiding this comment.
Is there some methods to remove here ?
Like supportsDenormalization which is already in the trait if I read correctly
| * | ||
| * @throws NotNormalizableValueException | ||
| * | ||
| * @todo This method should be deprecated in 5.x, use ItemDenormalizer instead |
Contributor
There was a problem hiding this comment.
Same, could it call ItemDenormalizer::denormalize ?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
soyuka
force-pushed
the
denormalizer
branch
6 times, most recently
from
6772b9e to
2799be4
Compare
| Q | A | ------------- | --- | Branch? | main | Tickets | prerequisite for api-platform#7710 | License | MIT | Doc PR | ∅ Extract a dedicated ItemDenormalizer alongside each ItemNormalizer (generic Serializer, JSON-LD, JSON:API) with shared logic in an ItemNormalizerTrait. Existing normalizers keep their denormalize support via the trait for BC. Symfony and Laravel DI register the new denormalizers.
The normalizer/denormalizer split accidentally dropped this override. Without it, JsonApi\Serializer\ItemNormalizer inherits the parent's generic implementation (returns ['object' => false] for any format), which breaks Symfony Serializer fast-path routing — a more generic normalizer can win for formats that should land on the JSON:API one. Restored to the same shape kept by JsonLd\Serializer\ItemNormalizer post-split, matching the pre-split behavior.
#[IgnoreDeprecations] is required alongside expectUserDeprecationMessage() so --fail-on-deprecation does not flag the asserted deprecation in serializer/json-api ItemNormalizer/ItemDenormalizer tests.
Mirrors the split done for Serializer/JsonApi/JsonLd: introduces GraphQl\Serializer\ItemDenormalizer registered at priority -889 so Symfony's serializer dispatches mutation denormalization to it, avoiding the legacy ItemNormalizer::denormalize() deprecation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.