-
Notifications
You must be signed in to change notification settings - Fork 247
chore: validate sharding restore and incremental backups #9944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto Cherry-pick Instructions |
|
This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/ |
1 similar comment
|
This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9944 +/- ##
==========================================
+ Coverage 50.97% 51.72% +0.75%
==========================================
Files 541 541
Lines 58289 59006 +717
==========================================
+ Hits 29712 30522 +810
+ Misses 25656 25529 -127
- Partials 2921 2955 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if err = c.cleanupRestoreAnnotationForSharding(dag, spec.Name, restoreDoneForShardComponents); err != nil { | ||
| return err | ||
| } | ||
| continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cause restore shards count may be larger than backup.targets, when allocateTargetMap == targets, need to add skip annotations for the remaining shards to ensure deterministic status and tell the restore reconciler to skip them
resolved https://github.com/apecloud/apecloud/issues/15368
fix sharding restore and inc backup issues
current shards>backup target, can do restore, and skip the extra shards.latest backup shards(get from cluster snapshot)!=current shards, cannot do incremental backup