-
Notifications
You must be signed in to change notification settings - Fork 1
feat: use DateTime abstraction from apalis-sql
#30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: use DateTime abstraction from apalis-sql
#30
Conversation
- Add chrono and time feature flags - Use SqlDateTime, SqlDateTimeExt, TaskRow from apalis_sql - Use fully qualified syntax for trait methods - Update to apalis-core and apalis-sql beta.2
DateTime abstraction from apalis-sql
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@Himmelschmidt Did you run tests locally? I think you are basing your HEAD an old version and need to rebase |
I have run the tests and aside from the doctest there were no failures. I didn't fix it before, figured it might be out of scope, fixed it now. But I don't think that's what you were talking about |
But the previous doctests passed, what changed? |
|
Use
DateTimeandDateTimeExtfrom apalis-sql instead of direct chrono dependency.Adds
chronoandtimefeature flags for datetime library selection.Related: apalis-dev/apalis#655