Skip to content

Conversation

@Himmelschmidt
Copy link

@Himmelschmidt Himmelschmidt commented Dec 26, 2025

Use DateTime and DateTimeExt from apalis-sql instead of direct chrono dependency.

Adds chrono and time feature flags for datetime library selection.

Related: apalis-dev/apalis#655

- Add chrono and time feature flags
- Use SqlDateTime, SqlDateTimeExt, TaskRow from apalis_sql
- Use fully qualified syntax for trait methods
- Update to apalis-core and apalis-sql beta.2
@Himmelschmidt Himmelschmidt changed the title feat: use SqlDateTime abstraction from apalis-sql feat: use DateTime abstraction from apalis-sql Jan 7, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/from_row.rs 88.88% 1 Missing ⚠️
src/lib.rs 50.00% 1 Missing ⚠️
src/shared.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@geofmureithi
Copy link
Member

@Himmelschmidt Did you run tests locally? I think you are basing your HEAD an old version and need to rebase

@Himmelschmidt
Copy link
Author

@Himmelschmidt Did you run tests locally? I think you are basing your HEAD an old version and need to rebase

I have run the tests and aside from the doctest there were no failures. I didn't fix it before, figured it might be out of scope, fixed it now.

But I don't think that's what you were talking about

@geofmureithi
Copy link
Member

I didn't fix it before, figured it might be out of scope, fixed it now.

But the previous doctests passed, what changed?

@geofmureithi
Copy link
Member

Commits must have verified signatures.

@Himmelschmidt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants