[ZEPPELIN-6406] Integrate interpreter config key constants#5184
Open
hyunw9 wants to merge 1 commit intoapache:masterfrom
Open
[ZEPPELIN-6406] Integrate interpreter config key constants#5184hyunw9 wants to merge 1 commit intoapache:masterfrom
hyunw9 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Upstream issue ZEPPELIN-6400 removed the
ZeppleinConfigurationdependency from the zeppelin-interpreter module and replaced it with a plain property-based approach.As a subtask, fix these problems
Config key String (e.g. "zeppelin.interpreter.connection.poolsize") are hardcoded as plain string in RemoteInterpreterServer.java, TimeoutLifecycleManager.java, and SchedulerFactory.java. so typos can only be caught at runtime.
The same keys are defined independently in ZeppelinConfiguration.ConfVars, creating drift risk between two modules.
TimeoutLifecycleManager.parseTimeValue() duplicates the logic of ZeppelinConfiguration.timeUnitToMill().
What type of PR is it?
Refactoring
Todos
InterpreterConfigKeysin zeppelin-common module@Deprecatedand delegated to ConfigTimeUtils in zeppelin-common moduleWhat is the Jira issue?
How should this be tested?
Questions: