YETUS-1277. Skip per-sub-check commit statuses under GitHub Actions#386
Merged
Conversation
Under GHA, Yetus encodes result severity (error:/warning:) in the GitHub commit status context string. Since GitHub keys statuses by context, a re-run that changes a check's outcome never overwrites the prior status. The per-sub-check detail is already available in the PR comment and the GHA step summary, so commit statuses are redundant under GHA.
Member
Author
|
Going to merge this so that we can try it on HBase. |
Contributor
|
I think this may have broken at least yamllint: https://github.com/whatsnowplaying/whats-now-playing/actions/runs/26241397286/job/77228411878 |
Member
Author
|
Oh what the heck?? I had green checks :( |
Contributor
|
My project runs main so I can see what breaks at least for my code paths. |
Member
Author
|
Investigating. |
Member
Author
Member
Author
|
I have a fix over on #388 . I'd love your feedback on it there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under GHA, Yetus encodes result severity (error:/warning:) in the GitHub commit status context string. Since GitHub keys statuses by context, a re-run that changes a check's outcome never overwrites the prior status. The per-sub-check detail is already available in the PR comment and the GHA step summary, so commit statuses are redundant under GHA.