You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR makes the JdbcExecutor more robust by removing the faulty use of
WayangCollections.getSingle() in the function findJdbcExecutionOperatorTaskInStage().
The faulty function could potentially throw an exception if there were zero or
multiple consumers on the channel. This could cause the following runtime errors:
"[] is not a singleton"
This change will guarantee that the function now checks the number of consumers
before trying to access them, returning null if it doesn’t match the execution
pattern.
This is a status quo change, removing unneeded runtime errors in the JDBC
execution path.
How is this PR related to #711 ? It seems they both server the same purpose, no?
The fix for the bug is implemented in the PR #711. The fix for the bug is implemented in the same way as in the findJdbcExecutionOperatorTaskInStage() method to fix the bug instead of WayangCollections.getSingle(). This PR is similar to the previous one in the sense that it is another fix for the robustness bug of JdbcExecutor. The only difference is the logic used to fix the bug in this PR is different from the previous one. The previous one could cause a bug due to the assumption made for the consumers. The reason for choosing to submit two PRs is that it is easier to review them separately. If you think the two PRs should be merged into one, I am happy to merge them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the JdbcExecutor more robust by removing the faulty use of
WayangCollections.getSingle() in the function findJdbcExecutionOperatorTaskInStage().
The faulty function could potentially throw an exception if there were zero or
multiple consumers on the channel. This could cause the following runtime errors:
"[] is not a singleton"
This change will guarantee that the function now checks the number of consumers
before trying to access them, returning null if it doesn’t match the execution
pattern.
This is a status quo change, removing unneeded runtime errors in the JDBC
execution path.