Conversation
Fix RST syntax in 'export_and_load_executable.py'
Summary of ChangesHello @ruslo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a rendering issue in the online documentation for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR correctly fixes the reStructuredText syntax for code-block directives in the export_and_load_executable.py tutorial by adding the required blank lines. This change should resolve the rendering issue on the documentation website.
Regarding the build issues you mentioned in the description, here are a couple of hints:
-
The
OSError: [Errno 13] Permission deniederror typically occurs whenpiptries to install packages into a system-protected directory. Using a Python virtual environment should resolve this. You can create one usingpython3 -m venv venvand activate it withsource venv/bin/activatebefore running the build script. -
For the
docker/bash.sherror,Unknown flag: -c, it's likely that the script passes arguments directly to the container's entrypoint. You might not need the-cflag. Try wrapping your command in quotes like this:./docker/bash.sh ci_gpu 'python3 -m pip install --quiet tlcpack-sphinx-addon==0.2.1 && python3 -m pip freeze'.
The code changes look good. Thank you for the contribution!
|
Hi @ruslo Thanks for looking into this. |
Fix RST syntax in 'export_and_load_executable.py'
The code is not correctly rendered here:
See the
code-blockparts:I guess the problem is about spaces. However, I was not able to build documentation locally. I checked the instructions from https://github.com/apache/tvm/tree/9eac0e1635c83904aedd1100c9471c608d89a7ad/docs#build-locally
Both ended up in error.
Hints are welcome 🙏