Open
Conversation
jt2594838
reviewed
Mar 23, 2026
Comment on lines
+507
to
+510
| bool ChunkReader::should_skip_page_by_time(int64_t min_time_hint) { | ||
| if (min_time_hint < 0) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Though rare, the timestamp can be negative.
May use the minimum of int64 for this case.
Comment on lines
+181
to
+185
| // Apply offset: skip this row. | ||
| if (remaining_offset_ > 0) { | ||
| remaining_offset_--; | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
May skip setting row_record's field if offset > 0.
Comment on lines
+328
to
+342
| } else { | ||
| if (time_iters_[index]) { | ||
| delete time_iters_[index]; | ||
| time_iters_[index] = nullptr; | ||
| } | ||
| if (value_iters_[index]) { | ||
| delete value_iters_[index]; | ||
| value_iters_[index] = nullptr; | ||
| } | ||
| if (tsblocks_[index]) { | ||
| ssi_vec_[index]->destroy(); | ||
| tsblocks_[index] = nullptr; | ||
| } | ||
| ret = E_OK; | ||
| } |
Contributor
There was a problem hiding this comment.
The failure status cannot be sensed in this branch. Is this safe?
| for (size_t i = 0; i < lower_case_column_names.size(); ++i) { | ||
| auto ind = table_schema->find_column_index(lower_case_column_names[i]); | ||
| if (ind < 0) { | ||
| delete time_filter; |
Contributor
There was a problem hiding this comment.
Why is time_filter deleted here?
|
|
||
| int TableQueryExecutor::query(const std::string& table_name, | ||
| const std::vector<std::string>& columns, | ||
| Filter* time_filter, Filter* id_filter, |
| int ret = E_OK; | ||
| TsFileMeta* tsfile_meta = tsfile_executor_->get_tsfile_meta(); | ||
| if (tsfile_meta == nullptr) { | ||
| return E_TSFILE_WRITER_META_ERR; |
|
|
||
| bool TsFileSeriesScanIterator::should_skip_chunk_by_time( | ||
| ChunkMeta* cm, int64_t min_time_hint) { | ||
| if (min_time_hint < 0 || cm->statistic_ == nullptr) { |
Contributor
There was a problem hiding this comment.
Beware of negative timestamp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
queryByRow(paths/table, offset, limit)for both tree and table model. Results are equivalent to “full query then skip firstoffsetrows and take at mostlimitrows,” but offset/limit are pushed down so that Chunk/Page-level skipping avoids decoding unnecessary data where possible.Changes
Tree model
TsFileReader::queryByRow(path_list, offset, limit)/TsFileTreeReader::queryByRow(devices, measurements, offset, limit).set_row_range(offset, limit)on SSI → Chunk/Page skipped by count. Multi-path: offset/limit applied in merge loop;min_time_hintused to skip stale Chunks.Table model
TsFileReader::queryByRow(table_name, column_names, offset, limit).remaining_offset >= device_row_count(Dense (in this codebase) means: within one device, every queried column has the same number of rows and the same timestamps.).set_row_range(offset, limit)on each column’s SSI → Chunk/Page skip by count.Review focus