fix: graceful error handling for incompatible TsFile data decoding#15
Merged
HTHou merged 1 commit intoApr 29, 2026
Merged
Conversation
When reading TsFile data created by incompatible SDK versions (e.g., Python SDK), the DeltaBinaryDecoder throws BufferUnderflowException. Previously this caused a 500 error with no user-facing explanation. Changes: - Catch BufferUnderflowException and other runtime exceptions in all TsFileDataReader query methods, allowing partial data to be returned - Add warnings field to DataReadResult and DataPreviewResponse to propagate decode error details to the frontend - Display warnings as an Alert in the data preview view when data cannot be fully decoded - Add i18n translations for warning message (en-US and zh-CN)
HTHou
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeltaBinaryDecoderthrowsBufferUnderflowException, which previously caused a 500 error with no user-facing explanationBufferUnderflowExceptionand other runtime exceptions in allTsFileDataReaderquery methods, allowing partial data to be returned instead of crashingwarningsfield toDataPreviewResponseto propagate decode error details to the frontend, and display them as an Alert in the data preview viewChanges
Backend:
TsFileDataReader: Added catch blocks forBufferUnderflowException,BufferOverflowException, andRuntimeExceptionin all data reading methods; collect warning messagesDataReadResult: Addedwarningsfield to carry decode warningsDataPreviewResponse: Addedwarningsfield with builder supportDataService: Pass warnings fromDataReadResultthrough to responseFrontend:
types.ts: Addedwarnings?: string[]toDataPreviewResponsedata-preview/index.vue: Display warnings as an Ant Design Alert when data cannot be fully decodeden-US.json/zh-CN.json: Added i18n translations for warning messageTest plan