Add connect_down_policy: 4 for empty reply#13069
Open
masaori335 wants to merge 2 commits intoapache:masterfrom
Open
Add connect_down_policy: 4 for empty reply#13069masaori335 wants to merge 2 commits intoapache:masterfrom
masaori335 wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an origin server accepts a TCP/TLS connection but closes it without sending any HTTP response, ATS does not mark the origin as down — even after exhausting all retry attempts. This can cause ATS to keep hammering a misbehaving origin on every request.
Fix
4, all failures covered by policy 3, plus the case whereserver_response_hdr_bytes == 0at the end of a transaction — i.e. the origin closed or reset the connection after the TCP handshake without sending any HTTP response.HttpSM::track_connect_fail()function was also refactored for clarity.on_connect: refuse|resetfeature (thank you, @bneradt )notes
Two cases are explicitly excluded: