hrw4u: Allows bulk compilation of many files (faster) #12865
+472
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwoop
force-pushed
the
HRW4UBulkCompile
branch
from
72029cf to
34d68f4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a shared CLI entrypoint for hrw4u/u4wrh that supports compiling many files in a single Python invocation, including a bulk input:output pair mode, and documents the new usage.
Changes:
- Introduce
run_main()intools/hrw4u/src/common.pyto handle single-file, multi-file, andinput:outputbulk compilation flows. - Update
scripts/hrw4uandscripts/u4wrhto userun_main()instead of duplicating CLI parsing logic. - Document bulk compilation usage; add a test utility helper for bulk runs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/hrw4u/tests/utils.py | Adds run_bulk_test() helper to validate bulk input:output compilation via subprocess. |
| tools/hrw4u/src/common.py | Adds run_main() implementing bulk compilation/multi-file CLI behavior shared by hrw4u and u4wrh. |
| tools/hrw4u/scripts/u4wrh | Switches script entrypoint to run_main(). |
| tools/hrw4u/scripts/hrw4u | Switches script entrypoint to run_main(). |
| doc/admin-guide/configuration/hrw4u.en.rst | Updates documentation with basic, multi-file, and bulk input:output usage examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I addressed CoPilot's suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No major changes here, just a way to rescript input:output pairs for bulk loading, since Python is slow at startup.