Lua plugin support for connection exempt list #12849
Conversation
shukitchan
changed the title
There was a problem hiding this comment.
Pull request overview
Adds Lua plugin bindings and documentation for managing the per-client connection limit exempt list via the new TS APIs introduced alongside proxy.config.http.per_client.connection.exempt_list (#12198).
Changes:
- Expose
ts.connection_limit_exempt_list_add/remove/clearin the Lua plugin misc API table. - Implement Lua-to-TS wrappers calling
TSConnectionLimitExemptListAdd/Remove/Clear. - Document the new Lua APIs in the Lua admin guide.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| plugins/lua/ts_lua_misc.cc | Adds Lua bindings for add/remove/clear of the connection limit exempt list. |
| doc/admin-guide/plugins/lua.en.rst | Documents the new Lua APIs with syntax, descriptions, and examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[approve ci format] |
|
[approve ci] |
1 similar comment
|
[approve ci] |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ts_lua_connection_limit_exempt_list_add(lua_State *L) | ||
| { | ||
| size_t len; | ||
| const char *ip_ranges; | ||
|
|
||
| ip_ranges = luaL_checklstring(L, 1, &len); |
There was a problem hiding this comment.
New Lua bindings for TSConnectionLimitExemptListAdd/Remove/Clear are introduced here, but there doesn't appear to be a corresponding gold test exercising these functions (e.g., success on valid ranges and failure on invalid input). Please add coverage under tests/gold_tests/pluginTest/lua to prevent regressions in the Lua API surface.
1 participant
This is related to #12198
Supporting the new API in lua plugin