Open
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Daniel-Dos
reviewed
Mar 15, 2026
examples/jpa-and-jakarta-data/src/main/resources/META-INF/persistence.xml
Show resolved
Hide resolved
Daniel-Dos
approved these changes
Mar 15, 2026
jungm
requested changes
Mar 16, 2026
...jb-jakarta-data/src/main/java/org/apache/openejb/data/extension/DataRepositoryExtension.java
Outdated
Show resolved
Hide resolved
...iner/openejb-jakarta-data/src/main/java/org/apache/openejb/data/meta/RepositoryMetadata.java
Outdated
Show resolved
Hide resolved
...-jakarta-data/src/main/java/org/apache/openejb/data/handler/RepositoryInvocationHandler.java
Outdated
Show resolved
Hide resolved
...-jakarta-data/src/main/java/org/apache/openejb/data/handler/RepositoryInvocationHandler.java
Show resolved
Hide resolved
...-jakarta-data/src/main/java/org/apache/openejb/data/handler/RepositoryInvocationHandler.java
Show resolved
Hide resolved
...-jakarta-data/src/main/java/org/apache/openejb/data/handler/RepositoryInvocationHandler.java
Show resolved
Hide resolved
...-jakarta-data/src/main/java/org/apache/openejb/data/handler/RepositoryInvocationHandler.java
Show resolved
Hide resolved
...-jakarta-data/src/main/java/org/apache/openejb/data/handler/RepositoryInvocationHandler.java
Show resolved
Hide resolved
...ainer/openejb-jakarta-data/src/main/java/org/apache/openejb/data/query/MethodNameParser.java
Outdated
Show resolved
Hide resolved
… comments
- Add tomee-hibernate container in arquillian.xml that swaps OpenJPA for
Hibernate via additionalLibs (remove:openjpa + mvn: Hibernate deps)
- Add third Surefire execution (tomee-hibernate) with jpa.provider=hibernate
- DataTCKArchiveProcessor selects provider based on jpa.provider system property
- Enable resource filtering for arquillian.xml to resolve version properties
- Skip OpenJPA mergeWithVersionCheck workaround for Hibernate/EclipseLink:
detect OpenJPA at runtime via isOpenJpa(), use standard em.merge() otherwise
- All three providers pass 98/98 TCK tests
jungm
requested changes
Mar 16, 2026
...-jakarta-data/src/main/java/org/apache/openejb/data/handler/RepositoryInvocationHandler.java
Outdated
Show resolved
Hide resolved
- jpqlCache (ConcurrentHashMap<Method, String>) stores JPQL strings with named parameter placeholders (:p0, :p1, etc.) — no bound values - Pre-computed at constructor time: findAllJpql, deleteAllJpql, countAllJpql — static per repository - Cached on first invocation: @query JDQL→JPQL expansion, @find+@by JPQL, @delete+@by JPQL, method-name find/count/delete/exists JPQL - Per-call: em.createQuery(cachedJpql) → bind parameters → execute - Dynamic Sort/Order params appended to the cached JPQL at execution time via appendDynamicSort
jungm
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(build with support of Claude)