TIKA-4705 -- resourceName of nested tarball should not contain the pa…#2730
Draft
iachimoe wants to merge 1 commit intoapache:branch_3xfrom
Draft
TIKA-4705 -- resourceName of nested tarball should not contain the pa…#2730iachimoe wants to merge 1 commit intoapache:branch_3xfrom
iachimoe wants to merge 1 commit intoapache:branch_3xfrom
Conversation
…rent directories of its parent gzip file.
tballison
reviewed
Apr 3, 2026
| if (StringUtils.isBlank(name)) { | ||
| return; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe use FilenameUtils.getName(name)
tballison
reviewed
Apr 3, 2026
| @Test | ||
| public void testNestedTarball() throws Exception { | ||
| List<Metadata> list = getRecursiveMetadata("test-nested-tarball.tar"); | ||
| List<String> actualInternalPaths = |
Contributor
There was a problem hiding this comment.
should be actualResourceNames
tballison
reviewed
Apr 3, 2026
| .map(m -> m.get(TikaCoreProperties.RESOURCE_NAME_KEY)) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| List<String> expectedInternalPaths = Arrays.asList("test-nested-tarball.tar", |
Contributor
There was a problem hiding this comment.
These should be just the file names, right?
tballison
reviewed
Apr 3, 2026
| "/nested.tgz/nested.tar/testTXT.txt", | ||
| "/nested.tgz/nested.tar", | ||
| "/nested.tgz"), actualEmbeddedPaths); | ||
| } |
Contributor
There was a problem hiding this comment.
Add test for internalPaths?
There are three things we care about with this change: resource names (should be just the file name), embedded resource path and the internal path.
tballison
reviewed
Apr 3, 2026
Contributor
tballison
left a comment
tballison
left a comment
There was a problem hiding this comment.
Please aim this against main. I'll cherrypick back to 3.x.
I think this makes sense and is a good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description of issue is at https://issues.apache.org/jira/browse/TIKA-4705