THRIFT-5967: Parallelize static code analysis run on GitHub#3443
Merged
kpumuk merged 1 commit intoapache:masterfrom May 3, 2026
Merged
THRIFT-5967: Parallelize static code analysis run on GitHub#3443kpumuk merged 1 commit intoapache:masterfrom
kpumuk merged 1 commit intoapache:masterfrom
Conversation
sveneld
reviewed
May 3, 2026
Member
Author
|
Created an umbrella ticket https://issues.apache.org/jira/browse/THRIFT-5966 to add SCA for other libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SCA job runs as a single monolythic workflow, with each job checking different libraries separately. Jobs are allowed to fail, and there is a final summary job that check the status of each other job and fails if any failed. This makes it a little bit hard to read, makes the job slower, and somewhat hard to add new languages.
This pull request follows the similar structure we have in our
build.yml- each language gets its own job, that depends on compiler build (used to generate thrift and verify generated code to follow the same rules as the library itself).The time went down from 7m4s to 6m45s, which is not very significant, but that's pretty much a cap - compiler + cppcheck for C++ library, and the rest of the languages will finish in parallel before that, so it will never take longer. The old workflow would keep increasing the total time.
Additionally, replaces
sloccountwithscc, as it does not know the modern PHP syntax and was spitting lots of noise in the output:Nice and pretty now with https://github.com/apache/thrift/actions/runs/25285416874/job/74129027301
[skip ci]anywhere in the commit message to free up build resources.