Skip to content

fix: return -1 from getWorkerIndex for non-worker actor IDs #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ma77Ball wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −9
Open

fix: return -1 from getWorkerIndex for non-worker actor IDs #5006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a9f11e
return -1 from getWorkerIndex for non-worker actor IDs instead of thr…
Ma77Ball May 10, 2026
feb85d8
Merge branch 'main' into fix/getWorkerIndexMatchError
Ma77Ball May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions common/workflow-core/src/main/scala/org/apache/texera/amber/util/VirtualIdentityUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ object VirtualIdentityUtils {
workerId.name match {
case workerNamePattern(_, _, _, idx) =>
idx.toInt
case _ =>
// for special actorId such as SELF, CONTROLLER
-1
}
}

Expand Down
15 changes: 6 additions & 9 deletions .../workflow-core/src/test/scala/org/apache/texera/amber/util/VirtualIdentityUtilsSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,13 @@ class VirtualIdentityUtilsSpec extends AnyFlatSpec with Matchers {
VirtualIdentityUtils.getWorkerIndex(actor) shouldBe 42
}

it should "throw MatchError on non-worker actor names (current behavior)" in {
// getWorkerIndex pattern-matches on workerNamePattern with no fallback,
// so passing a special ActorVirtualIdentity like CONTROLLER or SELF
// yields scala.MatchError. Pinning this behavior here means a future
// change that adds a fallback (or a different exception) breaks this
// spec on purpose so the new contract is reviewed.
it should "fall back to -1 for non-worker actor names" in {
// Special ActorVirtualIdentity values like CONTROLLER or SELF do not
// match workerNamePattern. getWorkerIndex returns -1 as a sentinel
// rather than throwing scala.MatchError, mirroring the graceful
// handling in getPhysicalOpId and toShorterString.
val controller = ActorVirtualIdentity("CONTROLLER")
assertThrows[scala.MatchError] {
VirtualIdentityUtils.getWorkerIndex(controller)
}
VirtualIdentityUtils.getWorkerIndex(controller) shouldBe -1
}

// ----- toShorterString -----
Expand Down