chore(deps): drop unused content-disposition dependency#4980
Open
aglinxinyuan wants to merge 2 commits intoapache:mainfrom
Open
chore(deps): drop unused content-disposition dependency#4980aglinxinyuan wants to merge 2 commits intoapache:mainfrom
aglinxinyuan wants to merge 2 commits intoapache:mainfrom
Conversation
`download.service.ts` had a top-level
`var contentDisposition = require("content-disposition")` that was never read
or called. Removed the dead require, then dropped both `content-disposition`
and `@types/content-disposition` from package.json (and the bundled-license
roll-up). yarn.lock loses the transitive entries for free.
Closes apache#4979.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused content-disposition require from the frontend download service and cleans up the corresponding direct dependencies and licensing manifests to keep the frontend dependency set lean.
Changes:
- Removed dead
require("content-disposition")fromdownload.service.ts. - Dropped
content-dispositionand@types/content-dispositionfromfrontend/package.json. - Updated
frontend/yarn.lockandfrontend/LICENSE-binaryto reflect the dependency cleanup.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/src/app/dashboard/service/user/download/download.service.ts |
Removes unused content-disposition require. |
frontend/package.json |
Deletes direct runtime + typings dependencies for content-disposition. |
frontend/LICENSE-binary |
Removes content-disposition@0.5.4 entry from the bundled license manifest. |
frontend/yarn.lock |
Regenerated lockfile reflecting dependency graph updates after removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nsitives The 5 packages flagged by check_binary_deps.py (base64-js, buffer, ieee754, path-browserify, safe-buffer) were only bundled because content-disposition pulled them in transitively. Once content-disposition itself is gone, they fall out of the webpack bundle and the LICENSE-binary entries are stale.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4980 +/- ##
============================================
- Coverage 42.71% 42.71% -0.01%
Complexity 2185 2185
============================================
Files 1032 1032
Lines 38161 38160 -1
Branches 4006 4006
============================================
- Hits 16301 16300 -1
Misses 20840 20840
Partials 1020 1020
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
download.service.tscarried a top-levelvar contentDisposition = require("content-disposition")that was never read or called. Removing the deadrequirelets us drop thecontent-dispositionruntime dep and its@types/content-dispositioncompanion, plus the now-stale bundled-license entries for the transitive packages that fell out with it.frontend/src/app/dashboard/service/user/download/download.service.tsrequire("content-disposition")linefrontend/package.jsoncontent-disposition(deps) and@types/content-disposition(devDeps)frontend/LICENSE-binarycontent-disposition@0.5.4plus 5 transitives no longer bundled (base64-js,buffer,ieee754,path-browserify,safe-buffer)frontend/yarn.lockBefore → After (
download.service.ts):Any related issues, documentation, discussions?
Closes #4979.
How was this PR tested?
yarn installsucceeds and rewritesyarn.lock(transitive entries fall away)yarn buildexits 0yarn teststays at 63 / 269 paritycheck_binary_deps.py --ignore-transitive-version npm …/3rdpartylicenses.jsonwill be the final arbiter on the LICENSE-binary cleanupWas this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)