Skip to content

fix: replace bare Option.get in getPortId with descriptive IllegalStateException #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ma77Ball wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

fix: replace bare Option.get in getPortId with descriptive IllegalStateException #4978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d7156b
throw IllegalStateException with context in getPortId before setPortId
Ma77Ball May 7, 2026
fbefa1a
Merge branch 'main' of github.com:apache/texera into fix/getPortId
Ma77Ball May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...n/scala/org/apache/texera/amber/engine/architecture/messaginglayer/AmberFIFOChannel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ class AmberFIFOChannel(val channelId: ChannelIdentity) extends AmberLogging {
}

def getPortId: PortIdentity = {
this.portId.get
this.portId.getOrElse(
throw new IllegalStateException(
s"portId has not been set for channel $channelId; call setPortId before getPortId"
)
)
}
}
7 changes: 4 additions & 3 deletions ...ala/org/apache/texera/amber/engine/architecture/messaginglayer/AmberFIFOChannelSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,13 @@ class AmberFIFOChannelSpec extends AnyFlatSpec {
// PortId association
// ---------------------------------------------------------------------------

"AmberFIFOChannel.getPortId" should "throw when no portId has been set" in {
"AmberFIFOChannel.getPortId" should "throw IllegalStateException with a descriptive message when no portId has been set" in {
val ch = new AmberFIFOChannel(cid)
// Option.get on None
assertThrows[NoSuchElementException] {
val ex = intercept[IllegalStateException] {
ch.getPortId
}
assert(ex.getMessage.contains("portId has not been set"))
assert(ex.getMessage.contains(cid.toString))
}

it should "return the most recently configured portId" in {
Expand Down
Loading