ci: wire Lakekeeper and MinIO into GitHub Actions#4276
Draft
mengw15 wants to merge 3 commits intoapache:mainfrom
Draft
ci: wire Lakekeeper and MinIO into GitHub Actions#4276mengw15 wants to merge 3 commits intoapache:mainfrom
mengw15 wants to merge 3 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
engine
dependencies
mengw15
changed the title
Yicong-Huang
reviewed
May 9, 2026
Comment on lines
+47
to
+49
| s3fs==2025.9.0 | ||
| aiobotocore==2.25.1 | ||
| botocore==1.40.53 |
Contributor
There was a problem hiding this comment.
these requirements are for pyamber. if those are dev-only requirements, please add to dev-requirements.txt
Yicong-Huang
reviewed
May 9, 2026
Comment on lines
+40
to
+43
| // Fork a separate JVM for tests to avoid sbt classloader conflicts | ||
| // (iceberg-aws S3FileIO hits ClassCastException with layered classloaders) | ||
| Test / fork := true | ||
| Test / baseDirectory := (ThisBuild / baseDirectory).value |
Contributor
There was a problem hiding this comment.
do we really have to bundle min io and its tests into workflow-core?
Yicong-Huang
reviewed
May 9, 2026
Comment on lines
+50
to
+52
| s3_region="us-west-2", | ||
| s3_auth_username="texera_minio", | ||
| s3_auth_password="password", |
Contributor
There was a problem hiding this comment.
are those changes intentional?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out! This PR is still a draft, and I’ll do some cleanup before marking it ready for review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4276 +/- ##
============================================
+ Coverage 42.72% 42.78% +0.06%
- Complexity 2185 2189 +4
============================================
Files 1031 1031
Lines 38152 38152
Branches 4004 4004
============================================
+ Hits 16302 16325 +23
+ Misses 20831 20809 -22
+ Partials 1019 1018 -1
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add `amber-rest` and `python-rest` jobs to build.yml that boot a Lakekeeper REST catalog backed by MinIO and re-run the existing Scala and Python test suites with `STORAGE_ICEBERG_CATALOG_TYPE=rest`. The existing `amber` and `python` jobs continue to cover the Postgres catalog path; both backends are now exercised end-to-end. - `amber-rest`: starts MinIO + Lakekeeper (migrate -> serve -> health check -> init warehouse), runs `sbt "WorkflowCore/test" "WorkflowOperator/test" "WorkflowExecutionService/test"` against REST. - `python-rest`: same service setup; runs `pytest -sv` with REST env. - `common/workflow-core/build.sbt`: fork the test JVM only when `STORAGE_ICEBERG_CATALOG_TYPE=rest` is set, so iceberg-aws S3FileIO works under sbt's layered classloader. Postgres path unaffected. - Two test fixtures now read `catalog_type` from the env var (default `postgres`) so the same suite drives both backends without code edits. Closes apache#4994
Lakekeeper requires both PG_DATABASE_URL_READ and PG_DATABASE_URL_WRITE to be set (designed for primary + read-replica deployments). CI has a single Postgres so both point at the same URL; declare them once via the step env block and re-use across the migrate + serve docker invocations instead of repeating the literal string four times per job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add
amber-restandpython-restjobs to.github/workflows/build.ymlthat boot Lakekeeper + MinIO and re-run the existing Scala/Python test
suites with
STORAGE_ICEBERG_CATALOG_TYPE=rest. The existingamberandpythonjobs continue to cover the Postgres-catalog path, so bothbackends are now exercised end-to-end.
amber-restamber(sameDAO/PyBuilder/WorkflowCore/WorkflowOperator/WorkflowExecutionServicejacoco set)amber-restflagpython-restpython(pytest --cov)python-restflag; pinned to Python 3.12 (REST coverage is integration, not version-compat)Two supporting changes outside the workflow YAML, both necessary for the
new jobs to actually run:
common/workflow-core/build.sbt: fork the test JVM only whenSTORAGE_ICEBERG_CATALOG_TYPE=restis set, becauseiceberg-awsS3FileIOtrips aClassCastExceptionunder sbt's layered classloader.Postgres path is unaffected.
amber/src/test/python/.../test_iceberg_document.pyandtest_large_binary_manager.py: readcatalog_typefrom the env var(default
postgres), so the same fixtures drive both backends withouthardcoded flips.
Any related issues, documentation, discussions?
Closes #4994 (sub-issue of #4126)
How was this PR tested?
CI itself — the new
amber-restandpython-restjobs run on everypush of this PR; failures (Lakekeeper boot, warehouse init, REST-path
test breakage) surface as red checks on those two job names.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)