Open
Conversation
jessicapriebe
force-pushed
the
ooc/operators/cbind
branch
from
c2c4518 to
2e5c22a
Compare
Baunsgaard
reviewed
Feb 26, 2026
Comment on lines
+54
to
+91
| @Test | ||
| public void testCBindAppendBlock() { runCBindTest(1000, 1000, 1000, 1000);} | ||
|
|
||
| @Test | ||
| public void testCBindAppendBlockTwoLeftBlocks() {runCBindTest(1000, 2000, 1000, 1000);} | ||
|
|
||
| @Test | ||
| public void testCBindPartialFillSingleRightBlock() { runCBindTest(1000, 1100, 1000, 100);} | ||
|
|
||
| @Test | ||
| public void testCBindTotalFillSingleBlockEachSide() { runCBindTest(1000, 500, 1000, 500);} | ||
|
|
||
| @Test | ||
| public void testCBindTotalFillTwoRightBlocks() { runCBindTest(1000, 3500, 1000, 1500);} | ||
|
|
||
| @Test | ||
| public void testCBindPartialFillMultipleBlocksEachSide() { runCBindTest(1000, 3100, 1000, 3200);} | ||
|
|
||
| @Test | ||
| public void testCBindTotalFillMultipleBlocksEachSide() { runCBindTest(1000, 3500, 1000, 3500);} | ||
|
|
||
| @Test | ||
| public void testCBindOverflowSingleRightBlock() { runCBindTest(1000, 1600, 1000, 600);} | ||
|
|
||
| @Test | ||
| public void testCBindOverflowMultipleRightBlocks() { runCBindTest(1000, 1600, 1000, 2600);} | ||
|
|
||
| @Test | ||
| public void testCBindOverflowTotalFilledSingleRightBlock() {runCBindTest(1000, 1100, 1000, 1000);} | ||
|
|
||
| @Test | ||
| public void testCBindOverflowTotalFilledTwoRightBlocks() {runCBindTest(1000, 1100, 1000, 2000);} | ||
|
|
||
| @Test | ||
| public void testCBindMultipleRows() { runCBindTest(2500, 1500, 2500, 1500);} | ||
|
|
||
| @Test | ||
| public void testCBind() {runCBindTest(2300, 1655, 2300, 2542);} |
Contributor
There was a problem hiding this comment.
- I would suggest you change it to a parameterised test case to reduce line count.
- you are missing tests for other block sizes than default.
- You are missing negative cases where the r1 != r2, r1 == 0 && r2 == 0, and such.
Contributor
There was a problem hiding this comment.
These edge cases are indeed good to have. Currently, OOC largely misses these tests for other operators as well (I will work on it to increase coverage). As I am aware of some bugs for different block sizes, I suggest leaving the block size constant for now (but keep the block size parameter like you did in the last commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds OOC cbind.