[Bug] fix duplicate application restarts and alerts. #4326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…normal application restarts.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Issue Number: close #4301
Since the status of all applications is checked every 5 seconds, if the check cannot be completed within 5 seconds, it will cause the thread pool queue to accumulate. As a result, there may be multiple duplicate applications waiting in the thread pool queue, such as the same failed task that needs to be restarted appearing multiple times. This can lead to repeated application restarts and duplicate alerts.
Therefore, a WATCHING_IN_PROGRESS set is added here. If an application is already being watched, it will be skipped to ensure that there are no duplicate tasks in the thread pool queue.
Brief change log
fix duplicate application submissions and alerts when thread pool queue accumulates and failed task needs to be restarted
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts