Extract WaitAckCache to deduplicate OpenSearch bulk response handling#1869
Open
Extract WaitAckCache to deduplicate OpenSearch bulk response handling#1869
Conversation
…rch bolts The waitAck cache logic and bulk response processing were duplicated across DeletionBolt, IndexerBolt, and StatusUpdaterBolt. This extracts the shared logic into a new WaitAckCache class and adds unit tests covering the core scenarios (success, failure, conflicts, eviction, duplicate doc IDs). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Julien Nioche <julien@digitalpebble.com>
5 tasks
Signed-off-by: Julien Nioche <julien@digitalpebble.com>
… working in my spare time) Signed-off-by: Julien Nioche <julien@digitalpebble.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeletionBolt,IndexerBolt, andStatusUpdaterBoltinto a new sharedWaitAckCacheclassWaitAckCachecovering success, failure, conflicts, eviction, duplicate doc IDs (Elasticsearch IndexerBolt: tuples with canonical URL may not get acked #832), and edge cases — no OpenSearch container neededTest plan
mvn test -pl external/opensearch -Dtest=WaitAckCacheTest— all 11 new unit tests passmvn compile -pl external/opensearch -am— clean compileIndexerBoltTest,StatusBoltTest) pass against OpenSearch container🤖 Generated with Claude Code