[SPARK-57054][SQL] Make view collation sticky across ALTER SCHEMA DEFAULT COLLATION#56100
Open
ilicmarkodb wants to merge 1 commit into
Open
[SPARK-57054][SQL] Make view collation sticky across ALTER SCHEMA DEFAULT COLLATION#56100ilicmarkodb wants to merge 1 commit into
ilicmarkodb wants to merge 1 commit into
Conversation
33345d8 to
2fbf5cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the
AlterViewAsrewrite case fromApplyDefaultCollation.resolveDefaultCollation. It used to fold the namespace's current default collation into a view whose persistedPROP_COLLATIONwas empty, on everyALTER VIEW AS.Why are the changes needed?
A view's collation should be fixed at creation time. The removed rewrite let a later
ALTER SCHEMA ... DEFAULT COLLATIONretroactively change an existing view's literal types on the nextALTER VIEW AS:Does this PR introduce any user-facing change?
Yes.
ALTER VIEW ASno longer picks up the namespace's current default collation for a view that was created without one — the view's collation stays sticky from creation.How was this patch tested?
Updated the existing V1 and V2 tests to assert the new sticky behavior.
Was this patch authored or co-authored using generative AI tooling?
No.