[MINOR][PYTHON][TESTS] Rename TVFParityTestsMixin to TVFParityTests#56037
Open
zhengruifeng wants to merge 1 commit into
Open
[MINOR][PYTHON][TESTS] Rename TVFParityTestsMixin to TVFParityTests#56037zhengruifeng wants to merge 1 commit into
zhengruifeng wants to merge 1 commit into
Conversation
The class in `test_parity_tvf.py` is named `TVFParityTestsMixin` even though it is the concrete test case for the file (inheriting from `ReusedConnectTestCase` and `TVFTestsMixin`). The tests are picked up by `unittest` via the inherited `TestCase`, so this is purely a naming issue, but the misleading suffix is inconsistent with every other Connect parity file (`TypesParityTests`, `ConfParityTests`, etc.). Rename it to `TVFParityTests` to match the convention. Generated-by: Claude Code claude-opus-4-7
zhengruifeng
force-pushed
the
tvf-parity-rename
branch
from
a0c78e7 to
116b9f5
Compare
HyukjinKwon
approved these changes
May 21, 2026
dongjoon-hyun
approved these changes
May 21, 2026
gaogaotiantian
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename the class in
python/pyspark/sql/tests/connect/test_parity_tvf.pyfromTVFParityTestsMixintoTVFParityTests.Why are the changes needed?
TVFParityTestsMixinis actually the concrete Connect parity test case for the file — it inherits fromReusedConnectTestCase(aunittest.TestCase) andTVFTestsMixin, so the tests are picked up and run by the defaultunittestloader. TheMixinsuffix is misleading and inconsistent with every other Connect parity file (TypesParityTests,ConfParityTests, etc.), all of which use a plain*ParityTestsname. This is a naming-convention fix; no test behavior changes.I scanned all 780 registered test modules in
dev/sparktestsupport/modules.pyfor the same pattern (file where every top-level class is suffixedMixin).test_parity_tvf.pyis the only occurrence.Does this PR introduce any user-facing change?
No. Test-only change.
How was this patch tested?
Existing tests. The class and its inherited test cases were already being collected by
unittest; only the class name changes.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code claude-opus-4-7