Skip to content

[SPARK-56729][SQL] ReplaceData and WriteDelta should implement SupportsNonDeterministicExpression #55692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pabloggarc wants to merge 2 commits into from
+14 −2
Closed

[SPARK-56729][SQL] ReplaceData and WriteDelta should implement SupportsNonDeterministicExpression #55692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a46548
[SPARK-56729][SQL] ReplaceData and WriteDelta should implement Suppor…
pabloggarc May 5, 2026
fd07c3f
trigger CI
pabloggarc May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,10 @@ case class ReplaceData(
originalTable: NamedRelation,
projections: ReplaceDataProjections,
groupFilterCondition: Option[Expression] = None,
write: Option[Write] = None) extends RowLevelWrite {
write: Option[Write] = None)
extends RowLevelWrite with SupportsNonDeterministicExpression {

override def allowNonDeterministicExpression: Boolean = true

override val isByName: Boolean = false
override val withSchemaEvolution: Boolean = false
Expand Down Expand Up @@ -435,7 +438,9 @@ case class WriteDelta(
originalTable: NamedRelation,
projections: WriteDeltaProjections,
groupFilterCondition: Option[Expression] = None,
write: Option[DeltaWrite] = None) extends RowLevelWrite {
write: Option[DeltaWrite] = None) extends RowLevelWrite with SupportsNonDeterministicExpression {

override def allowNonDeterministicExpression: Boolean = true

override val isByName: Boolean = false
override val withSchemaEvolution: Boolean = false
Expand Down
7 changes: 7 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,4 +1330,11 @@ class AnalysisErrorSuite extends AnalysisTest with DataTypeErrorsBase {
"INVALID_NON_DETERMINISTIC_EXPRESSIONS" :: Nil
)
}

test("SPARK-56729: ReplaceData and WriteDelta allow non-deterministic expressions") {
assert(classOf[SupportsNonDeterministicExpression].isAssignableFrom(classOf[ReplaceData]),
"ReplaceData should implement SupportsNonDeterministicExpression")
assert(classOf[SupportsNonDeterministicExpression].isAssignableFrom(classOf[WriteDelta]),
"WriteDelta should implement SupportsNonDeterministicExpression")
}
}