Add tests for supported compression types in RocksDB. #54256
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
We allow setting "spark.sql.streaming.stateStore.rocksdb.compression" config that specifies what compression types RocksDB will use (when using stateful operators). However, we don't explicitly list what types are supported and we don't have a unit test to require that these types are supported.
In this PR we explicitly list 6 supported formats and add unit test to guarantee these are supported.
This will prevent changes that can break support for some of these compression types.
Note that one compression type, "xpress" is not supported. Trying to set it in config leads to an error:
Compression type Xpress is not linked with the binary. So we will not add a test for it and will not declare it as supported in documentation.Does this PR introduce any user-facing change?
No.
How was this patch tested?
A unit test for supported compression types.
Was this patch authored or co-authored using generative AI tooling?
No.