[SPARK-55449][Geo][SQL] Enable WKB parsing and writing for Geography#54227
Open
uros-db wants to merge 5 commits intoapache:masterfrom
Open
[SPARK-55449][Geo][SQL] Enable WKB parsing and writing for Geography#54227uros-db wants to merge 5 commits intoapache:masterfrom
uros-db wants to merge 5 commits intoapache:masterfrom
Conversation
uros-db
commented
Feb 9, 2026
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@szehon-ho Please review.
Contributor
Author
Please note that the CI failure ( |
szehon-ho
approved these changes
Feb 11, 2026
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
looks good to me, minor code suggestions
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/geo/WkbReader.java
Outdated
Show resolved
Hide resolved
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/util/geo/WkbGeographyTest.java
Show resolved
Hide resolved
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/geo/WkbReader.java
Show resolved
Hide resolved
uros-db
commented
Feb 12, 2026
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
Thank you for the review @szehon-ho!
@cloud-fan please take a look. All checks green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement Geography coordinate validation in WKB parser:
Why are the changes needed?
Enable Geography parsing from WKB.
Does this PR introduce any user-facing change?
Yes, Geography coordinate values are now limited to the supported ranges for longitude and latitude.
How was this patch tested?
Added new unit tests.
Was this patch authored or co-authored using generative AI tooling?
Yes.