[SPARK-53504][SQL] Type framework #51467
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.types.ops | ||
|
|
||
| import org.apache.spark.sql.catalyst.encoders.AgnosticEncoder | ||
| import org.apache.spark.sql.types.{DataType, TimeType} | ||
|
|
||
| // Encode type values to external types, for instance to Java types. | ||
| trait EncodeTypeOps { | ||
| // Gets an agnostic encoder which contains all info needed to convert internal row | ||
| // values of the given type to a specific objects. | ||
| def getEncoder: AgnosticEncoder[_] | ||
| } | ||
|
|
||
| object EncodeTypeOps { | ||
| private val supportedDataTypes: Set[DataType] = | ||
| Set(TimeType.MIN_PRECISION to TimeType.MAX_PRECISION map TimeType.apply: _*) | ||
|
|
||
| def supports(dt: DataType): Boolean = supportedDataTypes.contains(dt) | ||
| def apply(dt: DataType): EncodeTypeOps = TypeApiOps(dt).asInstanceOf[EncodeTypeOps] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.types.ops | ||
|
|
||
| import org.apache.spark.sql.types.{DataType, TimeType} | ||
|
|
||
| // Format type values to strings | ||
| trait FormatTypeOps { | ||
| // Formats times according to the pattern `HH:mm:ss.[..fff..]` where `[..fff..]` is a fraction | ||
| // of second up to microsecond resolution. It doesn't output trailing zeros in the fraction. | ||
| def format(v: Any): String | ||
| // Converts given value to a SQL typed literal | ||
| def toSQLValue(v: Any): String | ||
| } | ||
|
|
||
| object FormatTypeOps { | ||
| private val supportedDataTypes: Set[DataType] = | ||
| Set(TimeType.MIN_PRECISION to TimeType.MAX_PRECISION map TimeType.apply: _*) | ||
|
|
||
| def supports(dt: DataType): Boolean = supportedDataTypes.contains(dt) | ||
| def apply(dt: DataType): FormatTypeOps = TypeApiOps(dt).asInstanceOf[FormatTypeOps] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.types.ops | ||
|
|
||
| import java.time.LocalTime | ||
|
|
||
| import org.apache.spark.SparkException | ||
| import org.apache.spark.sql.catalyst.encoders.AgnosticEncoder | ||
| import org.apache.spark.sql.catalyst.encoders.AgnosticEncoders.LocalTimeEncoder | ||
| import org.apache.spark.sql.catalyst.util.TimeFormatter | ||
| import org.apache.spark.sql.types.TimeType | ||
|
|
||
| class TimeTypeApiOps(t: TimeType) | ||
| extends TypeApiOps | ||
| with EncodeTypeOps | ||
| with FormatTypeOps | ||
| with Serializable { | ||
| private lazy val fracFormatter = TimeFormatter.getFractionFormatter() | ||
|
|
||
| override def getEncoder: AgnosticEncoder[_] = LocalTimeEncoder | ||
|
|
||
| override def format(v: Any): String = v match { | ||
| case l: Long => fracFormatter.format(l) | ||
| case lt: LocalTime => fracFormatter.format(lt) | ||
| case other => | ||
| throw SparkException.internalError( | ||
| s"Unsupported external type ${other.getClass.getName} for the type ${t.sql}") | ||
| } | ||
| override def toSQLValue(v: Any): String = s"TIME '${format(v)}'" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.types.ops | ||
|
|
||
| import org.apache.spark.SparkException | ||
| import org.apache.spark.sql.types.{DataType, TimeType} | ||
|
|
||
| // Operations over a data type | ||
| trait TypeApiOps | ||
|
|
||
| // The factory of type operation objects. | ||
| object TypeApiOps { | ||
| def apply(dt: DataType): TypeApiOps = dt match { | ||
| case tt: TimeType => new TimeTypeApiOps(tt) | ||
| case other => | ||
| throw SparkException.internalError( | ||
| s"Cannot create an operation object of the type ${other.sql}") | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongjoon-hyun I have to violate the coding style because some GA fails and requires the formatting