Skip to content

Conversation

@CarterFendley
Copy link
Contributor

@CarterFendley CarterFendley commented Apr 19, 2025

What changes were proposed in this pull request?

To recommend the latest bug fixed version.

Why are the changes needed?

Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GHA.

Was this patch authored or co-authored using generative AI tooling?

No

@CarterFendley
Copy link
Contributor Author

Based on discussion from #50583

cc: @HyukjinKwon @dongjoon-hyun

@HyukjinKwon HyukjinKwon changed the title Minor update to example [MINOR][DOCS] Minor update to example Apr 20, 2025
HyukjinKwon
HyukjinKwon previously approved these changes Apr 20, 2025
@HyukjinKwon
Copy link
Member

Let's fix the linter tho.

zhengruifeng
zhengruifeng previously approved these changes Apr 21, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Apache Parquet 1.15.1 is partial, according to the ASF policy, I'd recommend not to mention this CVE in Apache Spark repository, @CarterFendley .

https://apache.org/security/committers.html#work-in-private

@dongjoon-hyun
Copy link
Member

Just a question for my understanding.

  • Is this based on the official Apache Parquet community CVE announcement?
  • If then, could you provide the Apache Parquet Security website link in this PR description, @CarterFendley ?

@HyukjinKwon HyukjinKwon dismissed their stale review April 22, 2025 06:24

Dismissed per Dongjoon's comment.

@CarterFendley
Copy link
Contributor Author

Hey sorry, just getting back to this now after a busy week. Apologies for the delay, thanks for all the comments.

@dongjoon-hyun I am a little confused. The CVE has been publicly announced on April 1st, the work done to patch the parquet-java package was done in private in March. Would you still like me to remove mention of the CVE even though it is public now? Just want to make sure.

With respect to this:

Is this based on the official Apache Parquet community CVE announcement?

No, there are some threads on the community mailing list but this just in reaction to the CVE announcement.

@CarterFendley
Copy link
Contributor Author

@HyukjinKwon Will fix the linter after I get the final word on what should be done with regards to the mention of the CVE or not 🫡

@dongjoon-hyun
Copy link
Member

@CarterFendley To be correct here, I get a chance to double-check the Parquet community mailing lists Today again. Here is the update as of now.

BTW, this PR looks a little misleading to me because we don't want to re-iterate all library CVEs announcement in Apache Spark documentation. Especially, when it's unable to affect Spark users. So, I can give +1 if you remove the CVE ID from this PR as I recommended. I believe that recommending new Parquet would be enough and sufficient in Apache Spark user perspective.

@CarterFendley
Copy link
Contributor Author

@dongjoon-hyun That is helpful context, and makes a lot more sense. I am not on many of those mailing lists so that is helpful to know. Thank you!

Especially, when it's unable to affect Spark users.

I am not sure about this. In the general case, yes I agree as stated on previous PRs. However with respect to this specific example, if the example is followed directly with a vulnerable version of the parquet-avro module, I believe it will lead users of Spark who are following it to be vulnerable.

The AvroParquetInputFormat class which this example is instructing users to supply is a part of the vulnerable module. And it appears to be connected to the vulnerable code (AvroParquetInputFormat > AvroReadSupport > AvroRecordConverter > FieldStringableConverter). As this is your area of expertise, not mine, please let me know if I have made a mistake here.

I will remove mention of the CVE due to the other considerations mentioned above, the context you provided me made sense!

@CarterFendley CarterFendley force-pushed the carter/minor-example-update branch from 08aa150 to 747a777 Compare April 28, 2025 23:14
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the ID. I also revised the PR description by removing the ID.

dongjoon-hyun pushed a commit that referenced this pull request Apr 29, 2025
### What changes were proposed in this pull request?

To recommend the latest bug fixed version.

### Why are the changes needed?

Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GHA.

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #50647 from CarterFendley/carter/minor-example-update.

Authored-by: carter.fendley <carter.fendley@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 84c9727)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member

Merged to master/4.0 for Apache Spark 4.0.0.

@CarterFendley
Copy link
Contributor Author

@dongjoon-hyun Sure thing, happy to help! I appreciate your feedback!

Thanks for all you do!

@dongjoon-hyun
Copy link
Member

Thank you for your efforts, @CarterFendley .

For the record, Apache Parquet 1.15.2 RC0 vote started.

yhuang-db pushed a commit to yhuang-db/spark that referenced this pull request Jun 9, 2025
### What changes were proposed in this pull request?

To recommend the latest bug fixed version.

### Why are the changes needed?

Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GHA.

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#50647 from CarterFendley/carter/minor-example-update.

Authored-by: carter.fendley <carter.fendley@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
### What changes were proposed in this pull request?

To recommend the latest bug fixed version.

### Why are the changes needed?

Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GHA.

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#50647 from CarterFendley/carter/minor-example-update.

Authored-by: carter.fendley <carter.fendley@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 0766f11)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants