-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][DOCS] Minor update to example #50647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR][DOCS] Minor update to example #50647
Conversation
|
Based on discussion from #50583 |
|
Let's fix the linter tho. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Apache Parquet 1.15.1 is partial, according to the ASF policy, I'd recommend not to mention this CVE in Apache Spark repository, @CarterFendley .
|
Just a question for my understanding.
|
|
Hey sorry, just getting back to this now after a busy week. Apologies for the delay, thanks for all the comments. @dongjoon-hyun I am a little confused. The CVE has been publicly announced on April 1st, the work done to patch the parquet-java package was done in private in March. Would you still like me to remove mention of the CVE even though it is public now? Just want to make sure. With respect to this:
No, there are some threads on the community mailing list but this just in reaction to the CVE announcement. |
|
@HyukjinKwon Will fix the linter after I get the final word on what should be done with regards to the mention of the CVE or not 🫡 |
|
@CarterFendley To be correct here, I get a chance to double-check the Parquet community mailing lists Today again. Here is the update as of now.
BTW, this PR looks a little misleading to me because we don't want to re-iterate all library CVEs announcement in Apache Spark documentation. Especially, when it's unable to affect Spark users. So, I can give +1 if you remove the CVE ID from this PR as I recommended. I believe that recommending new Parquet would be enough and sufficient in Apache Spark user perspective. |
|
@dongjoon-hyun That is helpful context, and makes a lot more sense. I am not on many of those mailing lists so that is helpful to know. Thank you!
I am not sure about this. In the general case, yes I agree as stated on previous PRs. However with respect to this specific example, if the example is followed directly with a vulnerable version of the The I will remove mention of the CVE due to the other considerations mentioned above, the context you provided me made sense! |
08aa150 to
747a777
Compare
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing the ID. I also revised the PR description by removing the ID.
### What changes were proposed in this pull request? To recommend the latest bug fixed version. ### Why are the changes needed? Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No Closes #50647 from CarterFendley/carter/minor-example-update. Authored-by: carter.fendley <carter.fendley@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 84c9727) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/4.0 for Apache Spark 4.0.0. |
|
@dongjoon-hyun Sure thing, happy to help! I appreciate your feedback! Thanks for all you do! |
|
Thank you for your efforts, @CarterFendley . For the record, Apache Parquet 1.15.2 RC0 vote started. |
### What changes were proposed in this pull request? To recommend the latest bug fixed version. ### Why are the changes needed? Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50647 from CarterFendley/carter/minor-example-update. Authored-by: carter.fendley <carter.fendley@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
### What changes were proposed in this pull request? To recommend the latest bug fixed version. ### Why are the changes needed? Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50647 from CarterFendley/carter/minor-example-update. Authored-by: carter.fendley <carter.fendley@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 0766f11) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
To recommend the latest bug fixed version.
Why are the changes needed?
Release Notes https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.1
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No