-
Notifications
You must be signed in to change notification settings - Fork 229
Improve document for IDE support and simplify doc build #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
| --mount type=bind,source="/path/to/spark-website",target="/spark-website" \ | ||
| -w /spark-website \ | ||
| docs-builder:latest \ | ||
| /bin/bash -c "sh .github/run-in-container.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github? Maybe it is better to be in dev?
developer-tools.md
Outdated
| <h4>IntelliJ</h4> | ||
|
|
||
| While many of the Spark developers use SBT or Maven on the command line, the most common IDE we | ||
| use is IntelliJ IDEA. You can get the community edition for free (Apache committers can get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no IDEA community edition now ...
https://blog.jetbrains.com/idea/2025/07/intellij-idea-unified-distribution-plan/
developer-tools.md
Outdated
| choose "Detect automatically" for `Generated source folders`, and choose "generate sources" for | ||
| `Phase to be used for folders update`. | ||
| - Go to `Settings -> Build, Execution, Deployment -> Compiler -> Scala Compiler -> Scala Compiler Server`, | ||
| pick a large enough number for `Maximum heap size, MB`, such as "16000". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default is 2g, which does not suffice for Spark, but 16g seems to be too aggressive, this might scare off many developers, I tested 4g also works
developer-tools.md
Outdated
|
|
||
| Make sure you have a clean start before setting up the IDE: A clean git clone of the Spark repo, install the latest | ||
| version of the IDE. If something goes wrong, clear the build outputs by `./build/sbt clean` and `./build/mvn clean`, | ||
| clear the m2 cache by `rm -rf ~/.m2/repository/*`, remove the IDE folder such as `.idea`, re-import the project into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks it's IDEA-specific, can we move this to IntelliJ section?
This PR does two things:
developer-tools.mdto give more details about IDE setup, w.r.t. my success tries