fill in missing test coverage for delete configset api#4407
Open
epugh wants to merge 1 commit intoapache:mainfrom
Open
fill in missing test coverage for delete configset api#4407epugh wants to merge 1 commit intoapache:mainfrom
epugh wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit test coverage for the DeleteConfigSet (v2) configsets delete API, primarily targeting input validation behavior without requiring ZooKeeper-backed deletion.
Changes:
- Introduces a new
DeleteConfigSetAPITestcovering “missing configset name” scenarios. - Verifies
BAD_REQUESTerror codes and basic error-message content for invalid inputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+71
to
+92
|
|
||
| @Test | ||
| public void testWhitespaceOnlyConfigSetNameThrowsBadRequest() { | ||
| final var api = new DeleteConfigSet(mockCoreContainer, null, null); | ||
| final var ex = assertThrows(SolrException.class, () -> api.deleteConfigSet(" ")); | ||
|
|
||
| assertEquals(SolrException.ErrorCode.BAD_REQUEST.code, ex.code()); | ||
| assertTrue( | ||
| "Error message should mention missing configset name", | ||
| ex.getMessage().contains("No configset name")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTabOnlyConfigSetNameThrowsBadRequest() { | ||
| final var api = new DeleteConfigSet(mockCoreContainer, null, null); | ||
| final var ex = assertThrows(SolrException.class, () -> api.deleteConfigSet("\t")); | ||
|
|
||
| assertEquals(SolrException.ErrorCode.BAD_REQUEST.code, ex.code()); | ||
| assertTrue( | ||
| "Error message should mention missing configset name", | ||
| ex.getMessage().contains("No configset name")); | ||
| } |
Comment on lines
+83
to
+92
| @Test | ||
| public void testTabOnlyConfigSetNameThrowsBadRequest() { | ||
| final var api = new DeleteConfigSet(mockCoreContainer, null, null); | ||
| final var ex = assertThrows(SolrException.class, () -> api.deleteConfigSet("\t")); | ||
|
|
||
| assertEquals(SolrException.ErrorCode.BAD_REQUEST.code, ex.code()); | ||
| assertTrue( | ||
| "Error message should mention missing configset name", | ||
| ex.getMessage().contains("No configset name")); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill in the missing test coverage for delete configset api. Split out of #4203