-
Notifications
You must be signed in to change notification settings - Fork 817
Upgrade to Lucene 10.4 #4195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rahulgoswami
wants to merge
7
commits into
apache:main
Choose a base branch
from
rahulgoswami:lucene1040
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade to Lucene 10.4 #4195
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
809ef97
upgrade Lucene to v10.4.0
rahulgoswami c4a7124
Fix PostingsFormat test failure
rahulgoswami 04b4190
Fix ScalarQuantizedDenseVectorFieldTest.fieldTypeDefinition_invalidBi…
rahulgoswami 37550e0
Changes for ScalarQuantizedVectorField (tests and documentation) due …
rahulgoswami e7c49e2
changelog
rahulgoswami 576b18e
Deprecate properties now unsupported in Lucene 10.4 and add Deprecate…
rahulgoswami 29d3a64
re-word deprecation notice in dense-vector-search.adoc for unsupporte…
rahulgoswami File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc | ||
| title: Upgrade to Lucene 10.4 | ||
| type: dependency_update | ||
| authors: | ||
| - name: Rahul Goswami | ||
| links: | ||
| - name: SOLR-18143 | ||
| url: https://issues.apache.org/jira/browse/SOLR-18143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,12 +17,14 @@ | |
| package org.apache.solr.schema; | ||
|
|
||
| import org.apache.lucene.codecs.KnnVectorsFormat; | ||
| import org.apache.lucene.codecs.lucene102.Lucene102HnswBinaryQuantizedVectorsFormat; | ||
| import org.apache.lucene.codecs.lucene104.Lucene104HnswScalarQuantizedVectorsFormat; | ||
| import org.apache.lucene.codecs.lucene104.Lucene104ScalarQuantizedVectorsFormat.ScalarEncoding; | ||
|
|
||
| public class BinaryQuantizedDenseVectorField extends DenseVectorField { | ||
|
|
||
| @Override | ||
| public KnnVectorsFormat buildKnnVectorsFormat() { | ||
| return new Lucene102HnswBinaryQuantizedVectorsFormat(getHnswM(), getHnswEfConstruction()); | ||
| return new Lucene104HnswScalarQuantizedVectorsFormat( | ||
| ScalarEncoding.SINGLE_BIT_QUERY_NIBBLE, getHnswM(), getHnswEfConstruction()); | ||
|
Comment on lines
-26
to
+28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ref. apache/lucene#15353 |
||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember the discussion thread about a Lucene upgrade that includes a Codec update, and needing to broadcast this fact in the upgrade notes page? This markdown file should explicitly add this step.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I remember a discussion thread regarding this. Quick search on the dev list wasn't helpful either. No mention of codec changes in the current
olr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoceither. Do you have a link to the discussion ?