SOLR-18101: SolrJ commit options, fluent API #4109
Draft
+92
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little bit of an API refresh on UpdateRequest/AbstractUpdateRequest to make it clearer how to send various commit options, and their relation to optimize & expungeDeletes.
Contributor
Author
|
This is a draft, not using the API just showing what I think it should be and what I want to deprecate. |
Contributor
|
Seems fine.. I'll be honest, I don't think I have strong opinons around this area... I almost never use SolrJ in my real world work, I only ever interact with it inside of Solr... I'm mostly in favour of anything that moves us forward, gets rid of waitFlush, and let's me remove more deprecated code in main. I may also just be a bit fatigued around all the change/discussion/work in the Java SolrCLient world ;-)! Not very helpful, I know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little bit of an API refresh on UpdateRequest/AbstractUpdateRequest to make it clearer how to send various commit options, and their relation to optimize & expungeDeletes.
https://issues.apache.org/jira/browse/SOLR-18101