SOLR-18083: Fix replication and other general operations in readOnly mode #4081
+59
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18083
Issues with readOnly:
One other issue during indexFetching a readOnly core is that if we want to delete all documents during a fetch, then we want to be able to open an indexWriter to clear the index. While this goes against the spirit of a readOnly core, we are replicating from the leader and want to be in-sync. So we should allow writing in this case.
So instead of just disallowing opening IndexWriters at all, we should allow opening an indexWriter with a flag that says it will be used in accordance with the spirit of read-only rules.