build, GHA workflow: remove DEVELOCITY_ACCESS_KEY #4077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want/use develocity integration for PR CI workflows.
janhoy
approved these changes
Jan 26, 2026
Contributor
janhoy
left a comment
janhoy
left a comment
There was a problem hiding this comment.
Good catch, and nice with a comment to inform future committers on why the scheduled workflow has it.
Q: Will the PR builds try to push to develocity and fail / log error, or is there another flag to enable/disable develocity?
Contributor
Author
|
BTW our develocity config is here. @clayburn I would ideally get your input on this... like do you think we maybe under-appreciate potential value of PR based build scans? I'd rather not even have to think of filtering them out when I'm on develocity.apache.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any PR based CI workflow results in develocity, so these keys here aren't doing anything. And I think that's a good thing any way -- I don't want the test history to be potentially influenced by the rate of PRs and flaky PRs -- work-in-progress, after all.
Only
docker-nightly.ymlis an exception, which is cron based, not PR based, and I do see it in develocity. Not that I find it useful ;-) but it at least makes sense to me that it be there -- consistency with cron/Jenkins builds.