-
Notifications
You must be signed in to change notification settings - Fork 809
SOLR-17821: Fix error scenario for ShardInstall or Restore #3434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SOLR-17821: Fix error scenario for ShardInstall or Restore #3434
Conversation
|
Some of the code is kind of hacky right now. But the bad stuff shouldn't be too hard to clean up. |
|
The implementation works for InstallShard, but we need to add this same functionality to Restore as well. |
|
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
|
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
…restore-partial-success
https://issues.apache.org/jira/browse/SOLR-17821
The scenario:
Currently, the following happens:
What we want to happen:
waitForAllReplicasToBeHealthyoption to wait for the recoveries to finishThis requires a few changes:
CollectionHandlingUtilsneed to encode and save coreName with requests/responses, in order to distinguish multiple core requests sent to the same node.