Skip to content

Add unit tests for JDBCTopologyQueryDAO SQL building#13798

Closed
currenjin wants to merge 1 commit intoapache:masterfrom
currenjin:test/jdbc-topology-query-dao
Closed

Add unit tests for JDBCTopologyQueryDAO SQL building#13798
currenjin wants to merge 1 commit intoapache:masterfrom
currenjin:test/jdbc-topology-query-dao

Conversation

@currenjin
Copy link
Copy Markdown
Contributor

Add unit tests for JDBCTopologyQueryDAO SQL building

Add tests to verify the SQL query construction in JDBCTopologyQueryDAO, covering:

  • loadServiceRelationsDetectedAtServerSide with no serviceIds: no extra filter appended

  • loadServiceRelationsDetectedAtServerSide with single serviceId: and (source=? or dest=?) properly parenthesized

  • loadServiceRelationsDetectedAtServerSide with multiple serviceIds: OR conditions chained correctly with proper parentheses

  • loadInstanceRelationDetectedAtServerSide: bidirectional condition ((source=A and dest=B) or (source=B and dest=A)) is correctly formed

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.

  • Update the CHANGES log.

@currenjin
Copy link
Copy Markdown
Contributor Author

Consolidated into #13800.

@currenjin currenjin closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant