Add unit tests for JDBCTraceQueryDAO SQL building#13797
Closed
currenjin wants to merge 1 commit intoapache:masterfrom
Closed
Add unit tests for JDBCTraceQueryDAO SQL building#13797currenjin wants to merge 1 commit intoapache:masterfrom
currenjin wants to merge 1 commit intoapache:masterfrom
Conversation
2 tasks
Contributor
Author
|
Consolidated into #13800. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for JDBCTraceQueryDAO SQL building
Add tests to verify the SQL query construction in
JDBCTraceQueryDAO, covering:queryByTraceId: TABLE_COLUMN and trace_id conditions appear correctlyqueryBySegmentIdList: segment_id uses IN clause (not OR)queryByTraceIdWithInstanceId: both trace_id and service_instance_id IN clauses are properly enclosed with parentheses, with correct AND between themIf this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Update the
CHANGESlog.