alter rmq replicator unnecessary validation#460
alter rmq replicator unnecessary validation#460galaxy077 wants to merge 2 commits intoapache:masterfrom
Conversation
| add(ReplicatorConnectorConfig.SRC_ACL_ENABLE); | ||
| add(ReplicatorConnectorConfig.DEST_ACL_ENABLE); | ||
| add(ERRORS_TOLERANCE_CONFIG); | ||
| put(ReplicatorConnectorConfig.SRC_CLOUD, false); |
There was a problem hiding this comment.
If it is not a necessary parameter, can you consider removing it from the verification?
There was a problem hiding this comment.
It is also possible to remove them directly, but it is easier for me to extend or customize them. It would be better to extract the required parameters into a unified public class rather than write them for each connector
There was a problem hiding this comment.
In my opinion, after the connector is implemented, the necessary configuration has been determined. In the subsequent evolution and development, of course, it is possible to challenge the verification rules of these parameters, but it is a very low-frequency operation. For example, we have some differences now. However, after our discussion this time, after confirming those that are indeed required and those that are not, there may be basically no major changes.
I think what you said about unifying the necessary parameters is a good idea. However, each connector implementation may have different validation rules, not only necessary and non-essential parameters. Can you try to tidy up some parameters though? Let's do further discussions on specific parameters?
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.